Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filter out orphaned hosts and cloud instances from list of running #17815

Conversation

yrudman
Copy link
Contributor

@yrudman yrudman commented Aug 7, 2018

This PR:

  • adds virtual column Host#archived
  • modifies MiqExpressionin db/fixtures/miq_searches.yml to filter out orphaned hosts and cloud instances

Depends on #17819

Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1612982

BEFORE:
before - host running
before - cloud instances running

AFTER:
after host running
after - cloud instances running

@miq-bot add-label bug, reporting

@yrudman yrudman force-pushed the filter-out-archived-hosts-from-list-of-running branch from 9a1af4d to 8fa1279 Compare August 7, 2018 22:30
@miq-bot miq-bot added the wip label Aug 7, 2018
@yrudman yrudman force-pushed the filter-out-archived-hosts-from-list-of-running branch 4 times, most recently from 05adaf7 to 60ac4c5 Compare August 8, 2018 18:30
@yrudman yrudman changed the title [WIP] Filter out orphaned hosts from list of running Filter out orphaned hosts and cloud instances from list of running Aug 8, 2018
@miq-bot miq-bot removed the wip label Aug 8, 2018
@yrudman yrudman closed this Aug 9, 2018
@yrudman yrudman reopened this Aug 9, 2018
@yrudman yrudman force-pushed the filter-out-archived-hosts-from-list-of-running branch from 60ac4c5 to f6dcd71 Compare August 9, 2018 15:15
@miq-bot
Copy link
Member

miq-bot commented Aug 9, 2018

Checked commits yrudman/manageiq@33b801d~...f6dcd71 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0
1 file checked, 0 offenses detected
Everything looks fine. 👍

@yrudman
Copy link
Contributor Author

yrudman commented Aug 9, 2018

@miq-bot add-label gaprindashvili/no

Copy link
Member

@gtanzillo gtanzillo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 LGTM

@gtanzillo gtanzillo added this to the Sprint 93 Ending Aug 27, 2018 milestone Aug 15, 2018
@gtanzillo gtanzillo merged commit 5c20422 into ManageIQ:master Aug 15, 2018
@yrudman yrudman deleted the filter-out-archived-hosts-from-list-of-running branch August 15, 2018 18:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants